Improve Stratum container build script #903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yi-Tseng
commented
Jan 14, 2022
Yi-Tseng
commented
- Let the user decide the image tag
- Replace string with ${string//search/replace} instead of sed
added 2 commits
January 13, 2022 23:58
- Let user decide the image tag
- Replace string with ${string//search/replace} instead of sed
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 336 336
Lines 30397 30397
=======================================
Hits 23935 23935
Misses 6462 6462 |
Yi-Tseng
changed the title
bocon13
approved these changes
Feb 18, 2022
|
This looks like a bandaid fix that introduces inconsistency and does not address the underlying problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.