Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support P4 Studio 9.7.1 & 9.8.0 #912

Merged
merged 10 commits into from
Feb 11, 2022
Merged

Support P4 Studio 9.7.1 & 9.8.0 #912

merged 10 commits into from
Feb 11, 2022

Conversation

Yi-Tseng
Copy link
Contributor

@Yi-Tseng Yi-Tseng commented Jan 27, 2022 •
edited

Add support for Intel P4 Studio(aka SDE) version 9.7.1 and 9.8.0
This PR also deprecate old SDE 9.3.1 support and cleanup the PI_bf dependency

  • Find a better way to compare semantic version in bash
  • Test on HW switch
    Find a way to avoid including PI when building stratum_bfrt (Will remove PI after we deprecate 9.5.x)

@Yi-Tseng Yi-Tseng added the enhancement New feature or request label Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited

Codecov Report

Merging #912 (a2e4353) into main (f186165) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files         339      339           
  Lines       30925    30925           
=======================================
  Hits        24495    24495           
  Misses       6430     6430

@Yi-Tseng Yi-Tseng changed the title Support P4 Studio 9.8.0 Support P4 Studio 9.7.1 & 9.8.0 and cleanup PI dependency Feb 9, 2022
pudelkoM
pudelkoM previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@pudelkoM pudelkoM left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good cleanup here! Very much appreciated.
Only comment I have is, this could maybe be split up into multiple PRs once testing is finished? Remove 9.3.1 and cleanup PI. Then add 9.7.1 and 9.8.0. Maybe the numeric version as well.

@Yi-Tseng
Copy link
Contributor Author

Yi-Tseng commented Feb 9, 2022

Lots of good cleanup here! Very much appreciated. Only comment I have is, this could maybe be split up into multiple PRs once testing is finished? Remove 9.3.1 and cleanup PI. Then add 9.7.1 and 9.8.0. Maybe the numeric version as well.

will do, thanks

@Yi-Tseng Yi-Tseng changed the title Support P4 Studio 9.7.1 & 9.8.0 and cleanup PI dependency Support P4 Studio 9.7.1 & 9.8.0 Feb 10, 2022
@Yi-Tseng Yi-Tseng mentioned this pull request Feb 10, 2022
Merged
@Yi-Tseng Yi-Tseng marked this pull request as ready for review February 11, 2022 19:47
@Yi-Tseng Yi-Tseng merged commit e9cd11d into main Feb 11, 2022
@Yi-Tseng Yi-Tseng deleted the p4-studio-9.8.0 branch February 11, 2022 20:18
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 17, 2024
@ffoulkes
Support P4 Studio 9.7.1 & 9.8.0 (stratum#912)
d2dc6b5 
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 17, 2024
@ffoulkes
Support P4 Studio 9.7.1 & 9.8.0 (stratum#912)
38a896b 
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudelkoM pudelkoM pudelkoM approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yi-Tseng @pudelkoM