Default Bfrt legacy bytestring response flag to false #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
force-pushed
the
bfrt-legacy-bytestring-default-false
branch
4 times, most recently
from
b237ccf
to
4005412
Compare
pudelkoM
force-pushed
the
bfrt-legacy-bytestring-default-false
branch
from
4005412
to
0790dba
Compare
Codecov Report
@@ Coverage Diff @@
## main #918 +/- ##
==========================================
+ Coverage 79.09% 79.10% +0.01%
==========================================
Files 339 339
Lines 30938 30938
==========================================
+ Hits 24469 24474 +5
+ Misses 6469 6464 -5
|
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stratum-bfrt will now return canonical P4RT byte strings by default. The
enable_bfrt_legacy_bytestring_responsesflag will continue to exist and can be set totrueto retain the old behavior.