Do not expect or emit padded byte strings in BFRT P4Runtime translator

[Yi-Tseng]

• No need to add padding zeros when writing through the SDE wrapper since it will help add zeros before writing to the SDE
• Values from SDE wrapper for port number can be 1 or 2 bytes when we set incompatible_enable_bfrt_legacy_bytestring_responses to false

[pudelkoM]

low level driver being the SDE wrapper here? Or does the SDE accept truncated strings now?

[Yi-Tseng]

low level driver being the SDE wrapper here? Or does the SDE accept truncated strings now?

I mean SDE accepts truncated byte strings
I tested with SDE 9.7.0 and didn't see issues.

[pudelkoM]

Did you test the SDE with custom code? Because all translated entries still go through the wrapper, which does the padding. Either way, the wrapper will take care of it, no need to pad here.

[Yi-Tseng]

Did you test the SDE with custom code? Because all translated entries still go through the wrapper, which does the padding. Either way, the wrapper will take care of it, no need to pad here.

I was wrong, I didn't realized that the wrapper adds padding zeros before sending to the SDE

[codecov]

Codecov Report

Merging #938 (4b7d0a3) into main (9b2dc9a) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   79.20%   79.18%   -0.02%     
==========================================
  Files         339      339              
  Lines       30928    30924       -4     
==========================================
- Hits        24495    24488       -7     
- Misses       6433     6436       +3     

Impacted Files	Coverage Δ
...atum/hal/lib/barefoot/bfrt_p4runtime_translator.cc	96.84% <66.66%> (-0.66%)	⬇️

[pudelkoM]

Did you test the SDE with custom code? Because all translated entries still go through the wrapper, which does the padding. Either way, the wrapper will take care of it, no need to pad here.

I was wrong, I didn't realized that the wrapper adds padding zeros before sending to the SDE

No worries, I wasn't sure if the SDE changed either.