Fix workspace status script for out-of-git builds #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 79.28% 79.28%
=======================================
Files 342 342
Lines 31103 31103
=======================================
Hits 24659 24659
Misses 6444 6444 |
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from non-git source code, e.g. release tars, the
.gitdirectory is not present. This causes any bazel command to fail as the workspace status script exits with non-zero code. We fix this by checking for this condition and not emitting any stamping info in that case.Fixes #949