Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue processing future PacketIns on errors in Stratum-bfrt #970

Merged
merged 1 commit into from
May 18, 2022

Conversation

pudelkoM
Copy link
Member

@pudelkoM pudelkoM commented May 18, 2022

We discovered that Stratum-bfrt completely stops processing PacketIns after the first error. This is undesirable as PacketIns are independent and errors should not persist.

@pudelkoM pudelkoM requested a review from Yi-Tseng May 18, 2022 01:38
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #970 (1d365d2) into main (b0d7c60) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   79.26%   79.27%           
=======================================
  Files         342      342           
  Lines       31108    31115    +7     
=======================================
+ Hits        24659    24665    +6     
- Misses       6449     6450    +1     
Impacted Files Coverage Δ
stratum/hal/lib/barefoot/bfrt_packetio_manager.cc 88.05% <80.00%> (-0.07%) ⬇️

@pudelkoM pudelkoM force-pushed the bfrt-packetin-continue-on-error branch from 75e6bbd to 8d27dcb Compare May 18, 2022 19:54
@pudelkoM pudelkoM force-pushed the bfrt-packetin-continue-on-error branch from 8d27dcb to 1d365d2 Compare May 18, 2022 19:55
@pudelkoM pudelkoM merged commit 9d96373 into main May 18, 2022
@pudelkoM pudelkoM deleted the bfrt-packetin-continue-on-error branch May 18, 2022 22:04
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 18, 2024
…um#970)

Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 18, 2024
…um#970)

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant