Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p4c beyond incompatible optimization changes #977

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

pudelkoM
Copy link
Member

@pudelkoM pudelkoM commented Jun 3, 2022

This PR pulls in incompatible updates to p4c and adjusts our code to work with/around them. These fixes are incomplete and some tests need to be disabled.
The compiled main.p4 pipeline definition does not change.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #977 (80e8400) into main (adb9d67) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files         342      342           
  Lines       31109    31164   +55     
=======================================
+ Hits        24692    24736   +44     
- Misses       6417     6428   +11     
Impacted Files Coverage Δ
stratum/p4c_backends/fpm/hit_assign_mapper.h 100.00% <ø> (ø)
stratum/p4c_backends/fpm/hit_assign_mapper.cc 93.54% <100.00%> (-6.46%) ⬇️
...um/p4c_backends/fpm/pipeline_intra_block_passes.cc 92.80% <0.00%> (-2.88%) ⬇️
stratum/p4c_backends/test/test_inspectors.h 94.54% <0.00%> (-1.82%) ⬇️
stratum/p4c_backends/fpm/pipeline_block_passes.cc 90.57% <0.00%> (-0.53%) ⬇️
stratum/p4c_backends/fpm/utils.cc 88.25% <0.00%> (+0.40%) ⬆️

@pudelkoM pudelkoM marked this pull request as ready for review June 9, 2022 16:22
@pudelkoM pudelkoM merged commit db2b616 into main Jun 9, 2022
@pudelkoM pudelkoM deleted the p4c-breaking-opt-upgrade branch June 9, 2022 16:23
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 18, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 18, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant