Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's simple, django-filter #448

Open
engAmirEng opened this issue Jan 2, 2024 · 6 comments
Open

It's simple, django-filter #448

engAmirEng opened this issue Jan 2, 2024 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@engAmirEng
Copy link

engAmirEng commented Jan 2, 2024

Your competitor (graphene) supports relay based on django-filter, in the other hand you implement your own filter that has bugs and is not as good, existing projects use django-filter and if you support it then you are the obvious choices since you have a decent subscription support, so please do it

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@bellini666
Copy link
Member

Hi @engAmirEng ,

I do agree that having support for django-filter would be nice :)

Currently I'm lacking time for some improvements and when I do have I'm trying to solve other issues, but I can totally help and guide anyone wanting to tackle this issue. If you or anyone wants to try, ping me either here or on discord

@bellini666 bellini666 added enhancement New feature or request help wanted Extra attention is needed labels Jan 6, 2024
@callmeUmer
Copy link

@bellini666 I can dedicate my time on this issue, I would need a little bit of your guidance

@bellini666
Copy link
Member

@callmeUmer awesome! :)

And sure, let me know what you need. As I said, we can continue the discussion either here or you can ping me on discord: https://strawberry.rocks/discord . My username there is bellini

@arthanson
Copy link

Big +1 for Django-filter support. I noticed you used to have support (v0.1.8 or so) and then it was dropped when the switch to dataclasses was done. At https://github.com/netbox-community/netbox we were looking to switch from graphene to strawberry but the lack of django-filter support is a big problem, and django-filter is pretty much a standard now for a lot of Django projects.

@cpontvieux-systra
Copy link
Contributor

-1 for Django-filter. Most of bugs in graphene comes from the try to fit django-filter project into something not meant to be.
I prefer the simpler approach done for now in strawberry-django. django-filter has not been created to integrate in graphql project and try to doing it is not a good idea. By the way, the source code of django-filter is not that big, it’s easy to just use/adapt the right part than try to force-fit this project in a graphql context.

Sometimes, reuse is not the answer (even if most of the time it is).

P.S. I love django-filter by the way, just not for this use case.

@patrick91
Copy link
Member

@cpontvieux-systra I think I agree with you 😊 for someone like me who hasn't used django filters, would you be able to provide some of the reason why you don't think it is a good idea to integrate it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants