Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support strawberry 0.199.0+ #326

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: support strawberry 0.199.0+ #326

merged 1 commit into from
Aug 2, 2023

Conversation

bellini666
Copy link
Member

strawberry 0.199.0 changed the way generic type vars are handled to support the new generic syntax in Python 3.12.

This release adjusts our usage of generic type vars to match the new behaviour.

Fix #325

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (eafbffc) 87.90% compared to head (4dfbb23) 87.90%.

❗ Current head 4dfbb23 differs from pull request most recent head 9da65d0. Consider uploading reports for the commit 9da65d0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          33       33           
  Lines        2944     2944           
=======================================
  Hits         2588     2588           
  Misses        356      356           
Files Changed Coverage Δ
strawberry_django/utils/inspect.py 79.48% <0.00%> (ø)
strawberry_django/fields/base.py 95.91% <100.00%> (ø)
strawberry_django/optimizer.py 89.63% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

strawberry 0.199.0 changed the way generic type vars are handled
to support the new generic syntax in Python 3.12.

This release adjusts our usage of generic type vars to match the
new behaviour.

Fix #325
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@bellini666 bellini666 merged commit 89fb6d5 into main Aug 2, 2023
36 checks passed
@bellini666 bellini666 deleted the new_syntax branch August 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when using strawberry 0.199.0 and this package
3 participants