docs: Remove officially unmaintained project #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request removes a community package from the documentation that is no longer officially supported. The package in question is 'strawberry-django-jwt', which is a JWT implementation with Strawberry and Django. The removal aims to prevent confusion and keep the documentation clean and up to date. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Eraldo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -4,7 +4,6 @@ Those are some community maintained projects worth mentioning: | |||
|
|
|||
| | Project | Description | | |||
| | :----------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------: | | |||
| | [:material-github: strawberry-django-jwt](https://github.com/KundaPanda/strawberry-django-jwt) | :material-information: JWT implementation with Strawberry and Django. | | |||
There was a problem hiding this comment.
question (documentation): Clarify the reason for removing the strawberry-django-jwt project.
Could you please provide the reason for removing the strawberry-django-jwt project from the documentation? If it was intentional, consider adding a note explaining the reason for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing a community package that is officially not supported anymore and itself refers to the another mentioned (and listed in the docs) package that includes JWT token management.
My personal suggestion would be to remove the stale package to prevent confusing and keep things clean and up to date.
Types of Changes
Summary by Sourcery
This pull request updates the community projects documentation by removing the reference to the unmaintained 'strawberry-django-jwt' project to prevent confusion and keep the documentation up to date.