Fix: permissions on channels requests #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellini666
requested changes
Aug 7, 2023
| @@ -56,6 +57,17 @@ def test_is_authenticated(db, gql_client: GraphQLTestClient): | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.mark.django_db(transaction=True) | |||
| async def test_channels_authenticated( | |||
There was a problem hiding this comment.
Would be nice to have tests for both authenticated and non-authenticated (which would fail) for this
devkral
reviewed
Jan 25, 2024
| user = info.context.request.user | ||
| except AttributeError: | ||
| # this is a channels request | ||
| user = info.context["request"].user |
There was a problem hiding this comment.
why not always info.context["request"].user? It works in both cases
There was a problem hiding this comment.
When I wrote this PR context wasn't a dict on HTTP requests.
There was a problem hiding this comment.
You may want to use:
from strawberry_django.auth.utls import get_current_user
user = get_current_user(info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
fix #330
Checklist