Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DEBUG_TOOLBAR_CONFIG["SHOW_TOOLBAR_CALLBACK"] is not taken into … #367

Closed

Conversation

sergio-bershadsky
Copy link

@sergio-bershadsky sergio-bershadsky commented Sep 20, 2023

Fixes issue associated with SHOW_TOOLBAR_CALLBACK settings

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bellini666
Copy link
Member

Hi @sergio-bershadsky ,

Thank you! :)

The PR seems fine, just need to take a look at the pyright issues in it, after that it can be merged

@bellini666
Copy link
Member

This has been superseded by #384

@bellini666 bellini666 closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEBUG_TOOLBAR_CONFIG["SHOW_TOOLBAR_CALLBACK"] is not taken into account inside middleware
2 participants