-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix missing fields from auto generated connections #137
fix: Fix missing fields from auto generated connections #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
General suggestions:
- Consider dynamically determining the pagination state to accurately reflect the data available.
- Safeguard against potential
IndexError
when accessing the last element of an empty list. - Explore alternatives to using
type: ignore
for bypassing type checking, aiming to resolve underlying type mismatches.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 84.28% 85.20% +0.91%
==========================================
Files 15 16 +1
Lines 1559 1615 +56
Branches 256 261 +5
==========================================
+ Hits 1314 1376 +62
+ Misses 192 183 -9
- Partials 53 56 +3 |
CodSpeed Performance ReportMerging #137 will not alter performanceComparing Summary
|
b3740fd
to
3683bb3
Compare
We changed auto generated edges/connections to inherit from `relay.Edge`/`relay.Connection`, which requires some extra fields to be instantiated. Fix strawberry-graphql#97
3683bb3
to
e61dec5
Compare
@erikwrede @mattalbr can you take a look at this? Also, not sure why 2 tests are failing. From what I can tell they are not related to my changes here |
Bump: this pull request is fine, the 2 non passing tests were added by this commit: b62fe80 Therefore this should be merged into main. This relationship bug has been blocking people from doing the 0.3->0.4 migration. Also, a new PR should fix the non passing unit tests on Python 3.8 & 3.9. Seems like the culprit commit has been using new BigInt scalar, which fails in these tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfeito!
We changed auto generated edges/connections to inherit from
relay.Edge
/relay.Connection
, which requires some extra fields to be instantiated.Fix #97