Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to GitHub actions and add tests on windows #160

Closed
1 of 2 tasks
patrick91 opened this issue Sep 26, 2019 · 5 comments · Fixed by #1321
Closed
1 of 2 tasks

Move CI to GitHub actions and add tests on windows #160

patrick91 opened this issue Sep 26, 2019 · 5 comments · Fixed by #1321
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects

Comments

@patrick91
Copy link
Member

patrick91 commented Sep 26, 2019

There's a PR open for this, might be worth picking it up again: #148

So we can use GitHub Actions to run tests on windows as well as linux and Mac OS :)

TODO

  • Run release on github actions (currently it is on circle ci)
  • Run tests on windows
@patrick91 patrick91 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Sep 26, 2019
@zhidelev
Copy link

zhidelev commented Oct 5, 2019

Hello, @patrick91 , I would like to work on this issue. I decided to run tests on Windows and mypy tests failed because of the pytest_mypy plugin using https://pypi.org/project/capturer which does not support Windows. So I will think about a workaround for this case. Other test cases passed on Windows.

@patrick91
Copy link
Member Author

@zhidelev thanks! that's really appreciated!

@patrick91
Copy link
Member Author

Migration from circle ci to GitHub actions is done here: #954

@marcoacierno
Copy link
Member

The only thing left here is running tests on windows?

@patrick91
Copy link
Member Author

yup!

@BryceBeagle BryceBeagle added this to Backlog in strawberry Aug 7, 2021
@jkimbo jkimbo assigned jkimbo and unassigned jkimbo Sep 29, 2021
@ossareh ossareh mentioned this issue Oct 8, 2021
11 tasks
strawberry automation moved this from Backlog to Done Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants