Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asyncio.run instead of asgiref for benchmarks #3325

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jan 6, 2024

This makes the traces easier to read

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Merging #3325 (3a2eb63) into main (6cba67d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3325   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         485      485           
  Lines       30285    30292    +7     
  Branches     3746     3746           
=======================================
+ Hits        29263    29270    +7     
  Misses        833      833           
  Partials      189      189           

Copy link

codspeed-hq bot commented Jan 6, 2024

CodSpeed Performance Report

Merging #3325 will not alter performance

Comparing feature/asyncio-run-for-benchmark (3a2eb63) with main (6cba67d)

Summary

✅ 13 untouched benchmarks

@patrick91 patrick91 changed the title Use asyncio.run instead of asgiref Use asyncio.run instead of asgiref for benchmarks Jan 7, 2024
@patrick91 patrick91 marked this pull request as ready for review January 7, 2024 11:01
@patrick91 patrick91 merged commit ba65949 into main Jan 7, 2024
55 checks passed
@patrick91 patrick91 deleted the feature/asyncio-run-for-benchmark branch January 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant