Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Pydantic examples are now working properly. #3341

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

liuliuOD
Copy link
Contributor

@liuliuOD liuliuOD commented Jan 15, 2024

Description

I encountered some problems when I read the documentations, and finally solved the problems by modify some example codes.

This PR fix some broken example codes on the Pydantic documentation page.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • There isn't any issue has been opened.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@erikwrede
Copy link
Member

Hey there, thanks for the PR! Your PR description mentions broken GraphQL queries, but I don't see any in the diff. Is anything missing?

Copy link

Hi 👋 You can find a preview of the docs here:

https://beta.strawberry.rocks/docs/pr/3341/integrations/pydantic

@liuliuOD
Copy link
Contributor Author

Hey there, thanks for the PR! Your PR description mentions broken GraphQL queries, but I don't see any in the diff. Is anything missing?

Yeah, thank you for the review. I think it's just about the examples.

Let me modify the description of the PR.

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patrick91 patrick91 merged commit c26bb05 into strawberry-graphql:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants