Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in apollo extension. #3410

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

coady
Copy link
Member

@coady coady commented Mar 15, 2024

Description

Updates datetime.now in utc. Fixes #3409.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Mar 15, 2024

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release fixes a deprecation warning when using the Apollo Tracing
Extension.

Here's the tweet text:

🆕 Release (next) is out! Thanks to A. Coady for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @coady - I've reviewed your changes and they look great!

General suggestions:

  • Ensure consistency in datetime handling across the entire project to avoid potential issues with time comparisons.
  • Consider adding more context to the release notes about the deprecation warning fix, such as affected Python or dependency versions, to help users understand the impact of the change.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

strawberry/extensions/tracing/apollo.py Show resolved Hide resolved
strawberry/extensions/tracing/apollo.py Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@botberry
Copy link
Member

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Fix deprecation warning in apollo extension.

Here's the tweet text:

🆕 Release (next) is out! Thanks to A. Coady for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #3410 (d643728) into main (7c32111) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3410   +/-   ##
=======================================
  Coverage   96.47%   96.48%           
=======================================
  Files         509      509           
  Lines       32691    32691           
  Branches     5399     5399           
=======================================
+ Hits        31540    31541    +1     
+ Misses        940      939    -1     
  Partials      211      211           

Copy link

codspeed-hq bot commented Mar 15, 2024

CodSpeed Performance Report

Merging #3410 will not alter performance

Comparing coady:3409 (d643728) with main (7c32111)

Summary

✅ 13 untouched benchmarks

Copy link
Member

@DoctorJohn DoctorJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @coady! Straight forward change I recently applied to some personal projects myself. Not sure why the docs were reformatted, but our linter seems to be happy so thats fine.

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! And sorry for taking so long to merge this 😊

@patrick91 patrick91 merged commit 0c3f51a into strawberry-graphql:main Mar 30, 2024
65 checks passed
@patrick91 patrick91 deleted the 3409 branch March 30, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloTracingExtension raises deprecation warning.
4 participants