-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning in apollo extension. #3410
Conversation
Updates `datetime.now` in utc. Fixes strawberry-graphql#3409.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @coady - I've reviewed your changes and they look great!
General suggestions:
- Ensure consistency in datetime handling across the entire project to avoid potential issues with time comparisons.
- Consider adding more context to the release notes about the deprecation warning fix, such as affected Python or dependency versions, to help users understand the impact of the change.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
=======================================
Coverage 96.47% 96.48%
=======================================
Files 509 509
Lines 32691 32691
Branches 5399 5399
=======================================
+ Hits 31540 31541 +1
+ Misses 940 939 -1
Partials 211 211 |
CodSpeed Performance ReportMerging #3410 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @coady! Straight forward change I recently applied to some personal projects myself. Not sure why the docs were reformatted, but our linter seems to be happy so thats fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! And sorry for taking so long to merge this 😊
Description
Updates
datetime.now
in utc. Fixes #3409.Types of Changes
Issues Fixed or Closed by This PR
ApolloTracingExtension
raises deprecation warning. #3409Checklist