Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken documentation examples in page https://strawberry.rocks/docs/guides/dataloaders #3444

Closed
tejusp opened this issue Apr 10, 2024 · 6 comments

Comments

@tejusp
Copy link
Contributor

tejusp commented Apr 10, 2024

Example within https://strawberry.rocks/docs/guides/dataloaders#usage-with-context is broken and can't be run due to invalid imports.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@tejusp
Copy link
Contributor Author

tejusp commented Apr 10, 2024

This issue can be closed after merging #3445

@patrick91
Copy link
Member

@tejusp what error do you get?

@tejusp
Copy link
Contributor Author

tejusp commented Apr 10, 2024

image

Created another PR to fix it #3446

@patrick91
Copy link
Member

@tejusp what version of strawberry do you have? that error shouldn't be there anymore

@tejusp
Copy link
Contributor Author

tejusp commented Apr 10, 2024

I'm using strawberry-graphql==0.219.2 (it's just 2 months old. Released: Feb 6, 2024)

How can we ensure the documentation is backwards compatible ?

@patrick91
Copy link
Member

@tejusp I think we need to add a version selector to the docs, but I'd prefer to do that after v1 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants