Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click menu, "Edit tag [tagname]" suggests F2 works on all tags but only works on Title #1210

Closed
3 tasks done
SimonDedman opened this issue May 31, 2023 · 8 comments
Closed
3 tasks done
Assignees

Comments

@SimonDedman
Copy link

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug / To Reproduce
Collection tab: right click on the data in any column and the right click menu will offer "Edit tag [columnname] F2" but F2 does nothing if the right click menu is open, and if you left-click on a specific cell (column + row) then hit F2, it opens up the Title column for editing.

Expected behavior
Left click cell, F2 opens editing on that cell.

System Information:

  • Operating system: Xubuntu 23.04
  • Strawberry Version: 1.0.17
@jonaski jonaski self-assigned this Jun 7, 2023
@jonaski jonaski removed their assignment Jun 7, 2023
@jonaski
Copy link
Member

jonaski commented Jun 7, 2023

I assume you mean the playlist, not the collection?

@jonaski
Copy link
Member

jonaski commented Jun 7, 2023

This is a Qt 5 bug, works fine in Qt 6.

@jonaski jonaski closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@SimonDedman
Copy link
Author

Hmmm... I'm on Qt6.4.2 though?

You're right, playlist not collection.

@jonaski jonaski reopened this Jun 7, 2023
@jonaski jonaski self-assigned this Jun 7, 2023
@jonaski
Copy link
Member

jonaski commented Jun 7, 2023

Looks like the action shortcut is conflicting with some default shortcut in Qt. Removing the F2 shortcut from the action seem to fix it.

@jonaski jonaski closed this as completed Jun 7, 2023
@jonaski
Copy link
Member

jonaski commented Jun 7, 2023

Looks to be working now, tested both with Qt 5 and 6.

@SimonDedman
Copy link
Author

Cheers bud. Quick one thought - not sure if this is something I can fix my side or if you're going to push a fix?

"Removing the F2 shortcut from the action" - what do you mean by this precisely? Thanks

@jonaski
Copy link
Member

jonaski commented Jun 7, 2023

I've pushed a fix 5b60ea8. Apparently configuring F2 for the action (menu item), conflicting with a default shortcut, so you can still use F2 but it doesn't show that on the menu, and it works for all tags now.

@SimonDedman
Copy link
Author

Gotcha, cheers chap!

jonaski added a commit that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants