Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP archives are cataloged as songs which cannot be played #1274

Closed
3 tasks done
polsvoice opened this issue Sep 21, 2023 · 4 comments
Closed
3 tasks done

ZIP archives are cataloged as songs which cannot be played #1274

polsvoice opened this issue Sep 21, 2023 · 4 comments

Comments

@polsvoice
Copy link

polsvoice commented Sep 21, 2023

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
ZIP archives are added to the Collection as songs. When they show up in playlists, such as the smart playlist "dynamic random mix", these "songs" don't play. Instead, Strawberry just gets stuck buffering, and you have to manually switch to a different song.

If you manually try to play one of these archives (e.g. by double-clicking it in a playlist), you get this error:

Internal data stream error.

../gstreamer/subprojects/gstreamer/plugins/elements/gsttypefindelement.c(1257): gst_type_find_element_loop (): /GstPlayBin3:pipeline-5-pipeline/GstURIDecodeBin3:uridecodebin3/GstURISourceBin:urisourcebin14/GstParseBin:parsebin16/GstTypeFindElement:typefind: streaming stopped, reason not-linked (-1)

To Reproduce
Add a ZIP file to one of the folders used for your Collection. Re-scan your Collection by going to Tools > Update changed collection folders. Open your collection and double-click one of the archive files to add it to a playlist, and then double-click it in the playlist.

Expected behavior
I expected archives to be ignored and not cataloged.

Screenshots:

System Information:

  • Operating system: Garuda Linux Soaring, kernel Linux 6.5.3-zen1-1-zen
  • Strawberry Version: 1.0.18
@jonaski
Copy link
Member

jonaski commented Sep 23, 2023

I can't reproduce this. No zip files are added to the collection here.
What version of TagLib are you using?
Does the zip archives contain audio files, if so what format?

@polsvoice
Copy link
Author

How do I find the version of TagLib?

The ZIP archives contain audio files in OGG format which I downloaded from Bandcamp. I like to keep the archives for the sake of redundancy and they don't take up a lot of space.

@tormol
Copy link

tormol commented Oct 2, 2023

Thank you for fixing it despite marking it need-more-info!
I just experienced this issue with the strawberry version in Debian 12 (v1.0.14, with libtag1-dev v1.13-2), and building from master fixed it.

@jonaski
Copy link
Member

jonaski commented Oct 7, 2023

I just added a workaround ignoring all known file extensions for compressed formats. The bug is really in the TagLib library, because Strawberry adds all files that TagLib can identify tags for independent of file extension. Because Strawberry doesn't hard-code any formats it supports anywhere since the supported formats really depends on GStreamer and what GStreamer plugins are installed, and GStreamer supports all formats TagLib support and much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants