Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-core requirement from >=0.50, <=0.51 to >=0.50, <=0.53 #125

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Updates the requirements on windows-core to permit the latest version.

Release notes

Sourced from windows-core's releases.

0.52.0

This release includes updates to all crates. This includes the first update to the windows-sys crate in 8 months. It also includes the first published version of the riddle tool and the windows-version crate.

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.48.5...0.52.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [windows-core](https://github.com/microsoft/windows-rs) to permit the latest version.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.50.0...0.52.0)

---
updated-dependencies:
- dependency-name: windows-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 16, 2023
@lopopolo
Copy link
Collaborator

@astraw @Kijewski this looks good to me, can we merge and release this?

@lopopolo
Copy link
Collaborator

our crate is the only one in my chunky lockfile that pulls in old windows-targets:

error[duplicate]: found 2 duplicate entries for crate 'windows_x86_64_msvc'
    ┌─ /Users/lopopolo/dev/artichoke/artichoke/Cargo.lock:129:1
    │
129 │ ╭ windows_x86_64_msvc 0.48.5 registry+https://github.com/rust-lang/crates.io-index
130 │ │ windows_x86_64_msvc 0.52.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰────────────────────────────────────────────────────────────────────────────────^ lock entries
    │
    = windows_x86_64_msvc v0.48.5
      └── windows-targets v0.48.5
          └── windows-core v0.51.1
              └── iana-time-zone v0.1.58
                  └── spinoso-time v0.7.2
                      └── artichoke-backend v0.24.1
                          └── artichoke v0.1.0-pre.0
    = windows_x86_64_msvc v0.52.0
      └── windows-targets v0.52.0
          └── windows-sys v0.52.0
              ├── fd-lock v4.0.2
              │   └── rustyline v13.0.0
              │       ├── artichoke v0.1.0-pre.0
              │       └── artichoke-readline v1.1.0
              │           └── artichoke v0.1.0-pre.0 (*)
              ├── known-folders v1.1.0
              │   ├── artichoke-readline v1.1.0 (*)
              │   └── artichoke-repl-history v1.0.0
              │       └── artichoke v0.1.0-pre.0 (*)
              └── rustix v0.38.26
                  └── fd-lock v4.0.2 (*)

it looks like other users are impacted by this too.

@Kijewski Kijewski merged commit cc6411e into main Dec 30, 2023
54 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/windows-core-gte-0.50-and-lte-0.53 branch December 30, 2023 09:04
@Kijewski Kijewski added the Tier-1 Rust Tier-1 platform label Dec 30, 2023
@MarijnS95
Copy link
Contributor

MarijnS95 commented Jan 3, 2024

@Kijewski @astraw Note that dependabot has a longstanding bug with these version ranges. It should be lower than (< 0.53, or <= 0.52 albeit some folks find that hard to read as there's an implicit <= 0.52.999999999...), not lower than or equal to because no windows-core 0.53 version exists: https://crates.io/crates/windows-core/versions

A breaking change could be pushed in a potential future windows-core 0.53 release, making this crate fail to compile.

@astraw
Copy link
Member

astraw commented Feb 3, 2024

A breaking change could be pushed in a potential future windows-core 0.53 release, making this crate fail to compile.

PR to address this: #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Tier-1 Rust Tier-1 platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants