Replace winapi dependency with windows-sys
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kijewski
added
dependencies
Kijewski
force-pushed
the
pr-windows-sys
branch
5 times, most recently
from
743d01c
to
bc63d1d
Compare
[Some time ago] I spoke in favor of using [`winapi`] instead of [`windows-sys`], because it had fewer msrv bumps, and because it was used by e.g. `tokio`, and `chrono`, so even if it was not being developed for anymore, it still had a ton of users who would hopefully notice any bugs. By now `tokio` has switched to `windows-sys`, and `chrono` will too in the next release. I guess it's time then to make the switch, too. [Some time ago]: strawlab#35 [`winapi`]: https://crates.io/crates/winapi [`windows-sys`]: https://crates.io/crates/windows-sys
Kijewski
force-pushed
the
pr-windows-sys
branch
from
bc63d1d
to
c217dc6
Compare
astraw
approved these changes
Jan 9, 2023
|
Thanks. Sorry this took a while to review. |
|
So chrono 0.4 is still the active release branch, and is currently still maintaining an MSRV of 1.38. We're working on 0.5 (which requires 1.48) but that's not very close to being done. Would it be a big ask to request that this project keeps its MSRV at 1.38 for a bit longer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago I spoke in favor of using
winapiinstead ofwindows-sys, because it had fewer msrv bumps, and because it wasused by e.g.
tokio, andchrono, so even if it was not beingdeveloped for anymore, it still had a ton of users who would hopefully
notice any bugs.
By now
tokiohas switched towindows-sys, andchronowill too inthe next release. I guess it's time then to make the switch, too.