Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

Missing set_axis on segment #133

Open
brta-jc opened this issue Oct 29, 2017 · 3 comments
Open

Missing set_axis on segment #133

brta-jc opened this issue Oct 29, 2017 · 3 comments

Comments

@brta-jc
Copy link

brta-jc commented Oct 29, 2017

Hi all,
I am attempting to use SACMODEL_PERPENDICULAR_PLANE which as I understand requires setting a reference axis and tolerance using set_axis and set_eps_angle. However it appears in pcl_172.cpp and the consequent generated python that set_axis is commented out?

'pcl._pcl.SegmentationNormal' object has no attribute 'set_axis'

Is this feature not implemented yet?

@Cwiiis
Copy link

Cwiiis commented Nov 2, 2017

It looks like set_axis was disabled in commit 3e04e89 ...

@Cwiiis
Copy link

Cwiiis commented Nov 2, 2017

Any reason why this was disabled, @Sirokujira ? This makes a lot of the segmentation functions useless.

@Sirokujira Sirokujira added this to the v0.3.0 milestone Nov 13, 2017
@Sirokujira
Copy link
Collaborator

When I tried to implement it, I commented out the source code because of the following things.

・I did not know the description to implement as a method of the base class (Segmentation) without going through minipcl.
・Test code does not exist.
· There was no idea about a good method of testing.

As a current situation, if there is a change in the return value (coefficients) after calling the segment function
I am doing the test called ok, but I do not know if this is correct or not.
(Although it will be a test of setEpsAngle, it is unknown whether it is setAsix test)

@Sirokujira Sirokujira mentioned this issue Dec 7, 2017
Sirokujira added a commit that referenced this issue Dec 7, 2017
*Create Sphinx docs(#126#126, v0.3 Release Task list)

*Separate Test Module(#126#126, v0.3 Release Task list)

*visual.Show() Methods default argument Replace binary string(#124)

*SegmentationNormal set_axis Function Implemented(#133)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants