Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No lock in reject #374

Closed
AgrimPrasad opened this issue Dec 4, 2018 · 3 comments
Closed

No lock in reject #374

AgrimPrasad opened this issue Dec 4, 2018 · 3 comments

Comments

@AgrimPrasad
Copy link
Contributor

#318 and #327 added locks for ack/nack but there's still no lock for reject:

amqp/channel.go

Lines 1582 to 1587 in 27835f1

func (ch *Channel) Reject(tag uint64, requeue bool) error {
return ch.send(&basicReject{
DeliveryTag: tag,
Requeue: requeue,
})
}

Is there any reason for this or is it okay if I create a PR to fix this?

@michaelklishin
Copy link
Collaborator

No particular reason. Please submit a PR.

@AgrimPrasad
Copy link
Contributor Author

Sure, created #375

@michaelklishin
Copy link
Collaborator

Addressed in #375, thank you @AgrimPrasad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants