Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the benchmarks from https://github.com/spenczar/tdigest #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carbocation
Copy link

No description provided.

@carbocation
Copy link
Author

(Specifically, incorporates benchmarks from https://github.com/spenczar/tdigest/blob/master/benchmarks_test.go )

@carbocation
Copy link
Author

For what it's worth, the benchmarks aren't a great representation of real-world performance in my hands. Although the benchmarks seemingly favor tdigest by a wide margin, in actual use the streadway/quantile package had much better performance for the exact same task. The underlying task takes 440 seconds. The tdigest package added 4,000 seconds of overhead, while the streadway/quantile package added 2,800 seconds of overhead. The quantile compute time was dominated by sorting, while the tdigest compute time was dominated by waiting for a mutex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant