snapshotting fix #107
Merged
snapshotting fix #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t be snapshotted up until first change occured - it could result in multiple times of aggregates replaying from store (from potentially huge number of events) instead of be restored from snapshot
alanbem
force-pushed
the
snapshotting-fix
branch
from
9f9f581
to
5655783
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
===========================================
- Coverage 99.9% 99.9% -0.01%
+ Complexity 848 847 -1
===========================================
Files 112 112
Lines 2213 2212 -1
===========================================
- Hits 2211 2210 -1
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix edge-case where after snapshot storage was reset, aggregates wouldn't be snapshotted up until first change occurred - it could result in multiple times of aggregates replaying from store (from potentially huge number of events) instead of be restored from snapshot