Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener/subscription should be able to pick event that listening starts from #49

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

alanbem
Copy link
Member

@alanbem alanbem commented Oct 15, 2018

No description provided.

@alanbem alanbem self-assigned this Oct 15, 2018
@codecov-io
Copy link

codecov-io commented Oct 20, 2018

Codecov Report

Merging #49 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     99.83%   99.83%   +<.01%     
+ Complexity      688      687       -1     
============================================
  Files            97       95       -2     
  Lines          1824     1828       +4     
============================================
+ Hits           1821     1825       +4     
  Misses            3        3
Impacted Files Coverage Δ Complexity Δ
...c/Infrastructure/Event/LoggingListener/Factory.php 100% <100%> (ø) 3 <1> (ø) ⬇️
src/Domain/Event/Subscriber.php 100% <100%> (ø) 8 <0> (-1) ⬇️
src/Infrastructure/Event/LoggingListener.php 100% <100%> (ø) 13 <7> (+4) ⬆️
src/Domain/Event/Sourced/Subscription.php 100% <100%> (ø) 39 <1> (+1) ⬆️
...Sourced/Subscription/Event/SubscriptionStarted.php 100% <100%> (ø) 4 <2> (ø) ⬇️
src/Domain/Event/Listener/Commanding.php 100% <100%> (ø) 4 <4> (?)
src/Domain/Event/Listener/Identifying.php 100% <100%> (ø) 4 <4> (?)
...ture/Event/Subscription/EventSourcedRepository.php 100% <100%> (ø) 22 <5> (ø) ⬇️
src/Infrastructure/Event/NullListener.php 100% <100%> (ø) 2 <0> (-2) ⬇️
...Infrastructure/Event/Listener/CompositeFactory.php 100% <100%> (ø) 5 <4> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66acb40...565710c. Read the comment docs.

@alanbem alanbem changed the title listener/subscription should be able to pick event it starts listening from listener/subscription should be able to pick event that listened stream starts from Oct 21, 2018
@alanbem alanbem force-pushed the listener-selecting-starting-event branch from 38e74ae to 565710c Compare December 7, 2018 10:10
@alanbem alanbem changed the title listener/subscription should be able to pick event that listened stream starts from listener/subscription should be able to pick event that listening starts from Dec 7, 2018
@alanbem alanbem merged commit 7432a26 into master Dec 10, 2018
@alanbem alanbem deleted the listener-selecting-starting-event branch December 10, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants