Accelerate subscriptions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
============================================
+ Coverage 99.79% 99.79% +<.01%
+ Complexity 758 756 -2
============================================
Files 104 104
Lines 1982 1986 +4
============================================
+ Hits 1978 1982 +4
Misses 4 4
Continue to review full report at Codecov.
|
alanbem
force-pushed
the
accelerate-subscriptions
branch
from
e876271
to
17ab38b
Compare
…ate. Subscription itself do not need to replay all events - only "subscription started", "subscription restarted", "subscription completed" are needed and then single last "subscription listened to event" or "subscription ignored event" if exists. Unfortunately listeners still need all events.
alanbem
force-pushed
the
accelerate-subscriptions
branch
from
17ab38b
to
517607b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accelerate subscriptions but cutting replay time of their internal state.
Subscription itself do not need to replay all events - only "subscription started", "subscription restarted", "subscription completed" are needed and then single last "subscription listened to event" if exists.
Unfortunately listeners still need all events.