Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription continuous listening #94

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

alanbem
Copy link
Member

@alanbem alanbem commented Dec 15, 2019

From now on Subscription::subscribeTo(EventStore $store, int $limit) will try to listen all events up to $limit.
Until now subscription listened to event found at the moment of subscribing ignoring event that were added to the event store after that.

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #94 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     99.81%   99.81%   +<.01%     
- Complexity      821      826       +5     
============================================
  Files           109      109              
  Lines          2133     2146      +13     
============================================
+ Hits           2129     2142      +13     
  Misses            4        4
Impacted Files Coverage Δ Complexity Δ
src/Infrastructure/Event/Sourced/Subscription.php 100% <100%> (ø) 51 <13> (+5) ⬆️
...ucture/Event/Sourced/TransactionalSubscription.php 100% <100%> (ø) 22 <3> (ø) ⬇️
...ture/Event/Subscription/LazyLoadedSubscription.php 100% <100%> (ø) 11 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d0775...8b48def. Read the comment docs.

@alanbem alanbem force-pushed the subscription-continous-listening branch from 60e15a6 to 3e6520f Compare December 15, 2019 20:42
@alanbem alanbem force-pushed the subscription-continous-listening branch from 3e6520f to 8b48def Compare December 15, 2019 21:03
@alanbem alanbem merged commit 11c0edb into master Dec 15, 2019
@alanbem alanbem deleted the subscription-continous-listening branch December 15, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant