Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement os::windows::named-pipe completely #1

Closed
4 tasks done
Xaymar opened this issue Jun 30, 2018 · 2 comments
Closed
4 tasks done

Implement os::windows::named-pipe completely #1

Xaymar opened this issue Jun 30, 2018 · 2 comments
Labels
flag:enhancement New feature or request type:task Tasks that need to be done

Comments

@Xaymar
Copy link
Contributor

Xaymar commented Jun 30, 2018

The current state of the code relies on legacy code, which is horribly inefficient at the task presented. It does work, but it has a high overhead for very small tasks.

Tasks left to do:

  • Implement unique constructor, shared constructor, open constructor and destructor
  • Implement read, write and other functions that should return a waitable object (os::windows::overlapped?)
  • Write Test code
  • Test
@Xaymar Xaymar added flag:enhancement New feature or request type:task Tasks that need to be done labels Jun 30, 2018
@Xaymar
Copy link
Contributor Author

Xaymar commented Jul 1, 2018

First task complete, 2nd task about to be completed with another helper class.

Xaymar added a commit that referenced this issue Jul 1, 2018
@Xaymar
Copy link
Contributor Author

Xaymar commented Jul 7, 2018

Completed.

@Xaymar Xaymar closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:enhancement New feature or request type:task Tasks that need to be done
Projects
None yet
Development

No branches or pull requests

1 participant