Fix query string parsing for slobs banner #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avacreeth
pushed a commit
that referenced
this pull request
Dec 19, 2018
avacreeth
added a commit
that referenced
this pull request
Dec 20, 2018
* Banner Improvements (#1132) * Banner Improvements Adds nav params, fully clickable banner, and closeOnLink flag functionality * Add clarifying comment * Allow parsing of both linkTarget types to smooth out incremental rollout * Fix query string parsing for slobs banner (#1140) * upload the log file to the cache directory archive (#1139) * Updater bootstrap improvements (#1158) * Use electron-log for logging in the bootstrap * Specify utf8 encoding when reading cached roll values * Always specify a radix when using parseInt * Fix race condition concerning ensureDir and async To reproduce the issue here, delete %LocalAppData%\slobs-updater. The next time you start slobs, the folder will be created but the following command will fail, causing the updater to fail to start. * fix chatbox test (#1115) * Facebook hotfixes (#1167) * Handle the case when spawing the updater results in an error (#1184) * Revert "Handle the case when spawing the updater results in an error (#1184)" This reverts commit bef7cb2.
This was referenced Jul 6, 2022
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow admins on the website to create a banner with a link such as
Dashboard?subPage=facemasksorPlatformAppStore?appId=2and the button will take you there.