Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Node.js@4.0, iojs@3.0, iojs@3.3 #35

Closed
wants to merge 2 commits into from
Closed

build: Node.js@4.0, iojs@3.0, iojs@3.3 #35

wants to merge 2 commits into from

Conversation

MarkHerhold
Copy link
Contributor

Also cleaning up the minor version iojs releases.

Also cleaning up the minor version iojs releases.
- "2.0"
- "2.4"
- "iojs-1.0"
- "iojs-2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to the way we do the version numbers. We purposely do not use "iojs" in the strings as well as include the top and bottom minor on purpose :)

@dougwilson dougwilson self-assigned this Sep 11, 2015
@MarkHerhold
Copy link
Contributor Author

@dougwilson interesting. I have never seen anyone do the versions like that, but it makes sense. What is the rationale behind not using "iojs-*" though?

@dougwilson
Copy link
Member

I have never seen anyone do the versions like that, but it makes sense.

We put a lot of thought into it :)

What is the rationale behind not using "iojs-*" though?

Because it is unnecessary and makes it look separate, like segregation. We want to treat them equally.

@MarkHerhold MarkHerhold changed the title build: Node.js@4.0 build: Node.js@4.0, iojs@3.0, iojs@3.3 Sep 11, 2015
@dougwilson
Copy link
Member

Ok, so now that I'm at a computer and can look more into this, it looks like there is more work to be done before I can merge your PR. I don't want to undermine the work you put into this and make the commit and discredit you, so I'll provide the remaining work for this PR so you can accomplish the tasks :)

  1. Before we can add any new versions to our Travis CI, we need to ensure all of our sub dependencies are fully functional on those versions first.

a. The bytes module probably works, but does not list the support for 3.x or 4.x as official. Please get those added to that upstream Travis CI and validate functionality.
b. The iconv-lite module, which is a pretty core module for this library, is not listed to work, and looking at their Travis CI build, actually is currently failing against io.js 3.x (https://travis-ci.org/ashtuchkin/iconv-lite/jobs/79812129) and Node.js 4.x (https://travis-ci.org/ashtuchkin/iconv-lite/jobs/79812130). Please work with that upstream dependency such that it functions on 3.x and 4.x and is tested.
c. The unpipe module, which looks into weird details of streams, does not officially support io.js 3.x or Node.js 4.x. Please work on getting that module tested and updated to official support the two versions.

  1. We also need to examine the changelog of Node.js/io.js on majors to determine what is different, what the breaking changes are, and how do they relate to what this module does (unified changelog at https://github.com/nodejs/node/blob/master/CHANGELOG.md). This module deals with details of streams, and at a glance, it doesn't seem like there are any breaking streams-related changes. Please verify this and let me know.

Let me know as your progress through this and if you get stuck or anything!

@MarkHerhold
Copy link
Contributor Author

There needs to be a PR bot for stuff like this. :)

A PR for iconv-lite is already in progress: ashtuchkin/iconv-lite#105

@dougwilson
Copy link
Member

Ok, iconv-lite published version 0.4.12, which works! Updating everything now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants