-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Node.js@4.0, iojs@3.0, iojs@3.3 #35
Conversation
Also cleaning up the minor version iojs releases.
- "2.0" | ||
- "2.4" | ||
- "iojs-1.0" | ||
- "iojs-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to the way we do the version numbers. We purposely do not use "iojs" in the strings as well as include the top and bottom minor on purpose :)
@dougwilson interesting. I have never seen anyone do the versions like that, but it makes sense. What is the rationale behind not using "iojs-*" though? |
We put a lot of thought into it :)
Because it is unnecessary and makes it look separate, like segregation. We want to treat them equally. |
Ok, so now that I'm at a computer and can look more into this, it looks like there is more work to be done before I can merge your PR. I don't want to undermine the work you put into this and make the commit and discredit you, so I'll provide the remaining work for this PR so you can accomplish the tasks :)
a. The
Let me know as your progress through this and if you get stuck or anything! |
There needs to be a PR bot for stuff like this. :) A PR for |
Ok, |
Also cleaning up the minor version iojs releases.