Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump iconv-lite version #64

Closed
wants to merge 1 commit into from
Closed

Bump iconv-lite version #64

wants to merge 1 commit into from

Conversation

thasophearak
Copy link

This PR bump iconv-lite to 0.5.0.

It will be remove

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

deprecation message.

dougwilson
dougwilson requested changes Jul 19, 2019
View reviewed changes
Copy link
Member

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, though that should have been addressed in prior versions, and I don't see that listed in the iconv-lite changelog for 0.5.0.

Can you please link to the commit or issue in iconv-lite showing this fix is in 0.5.0 OR provide steps to reproduce the message?

@thasophearak
Copy link
Author

@dougwilson Sorry, it was indeed has been addressed in prior versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson requested changes

Assignees
No one assigned
Labels
awaiting more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thasophearak @dougwilson