Fetch more than one season at once #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dularion
requested changes
Dec 21, 2016
| @@ -115,7 +115,7 @@ | |||
| <div ng-show="!showLoading"> | |||
|
|
|||
| <button class="btn btn-primary" ng-click="addNewEpisode()">Add New Episode Manually</button> | |||
| <button class="btn btn-primary" ng-click="fetchAllEpisodesForSeason()" ng-if="!show.manualInput">Fetch all Episode for Season</button> | |||
| <button class="btn btn-primary" ng-click="fetchEpisodes()" ng-if="!show.manualInput">Fetch Episodes</button> | |||
There was a problem hiding this comment.
did you adjust the existing buttons functionality? How exactly does it work? if the user does not choose a season number, it will fetch all?
| }); | ||
| }; | ||
|
|
||
| $scope.fetchEpisodes = function(){ | ||
| alertify.set({ buttonReverse: true, labels: {ok: "OK", cancel : "Cancel"}}); | ||
| alertify.prompt("For which seasons would you like to fetch the episodes? (Leave blank to fetch for all seasons)", function (confirmed, season) { |
There was a problem hiding this comment.
maybe give user more clear instructions, for example that he can use 1-3 syntax.
| }); | ||
| return; | ||
| } else if (season.indexOf('-') > -1) { | ||
| var start = parseInt(season.substring(0, season.indexOf('-'))); |
There was a problem hiding this comment.
maybe safer approach is to split by '-' and then use the resulting array pos 0 and 1, trim them, and then parse them. Consider if the user types "1 - 5"
|
|
||
| var getEpisodesForSeasons = function (seasons) { | ||
| var promises = []; | ||
| for (var i = 0; i < seasons.length; i++) { |
There was a problem hiding this comment.
avoid for loops, use lodash _.forEach instead for legibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131