Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the dependency on TheMovieDb and made it optional #257

Merged
merged 1 commit into from Jan 17, 2017
Merged

Removed the dependency on TheMovieDb and made it optional #257

merged 1 commit into from Jan 17, 2017

Conversation

lclc98
Copy link
Collaborator

@lclc98 lclc98 commented Jan 17, 2017

Allowed for moviedb to not be used if the key is not present

@ManuGithubSteam
Copy link

Hmm ok, i think MovieDB is a great feat but i see where are you going with this :-)

@lclc98
Copy link
Collaborator Author

lclc98 commented Jan 17, 2017

MovieDB is great, but some people dont like all the details they require

@ManuGithubSteam
Copy link

Trash mail helps :)

Copy link
Member

@dularion dularion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! if you could look into not removing the initial settings check, but instead checking against another setting like upload directory, that would be great, then ill accept :)

}
});
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cant remove this part of the code, its important for the initial setup, but maybe query against another missing setting, like the upload directory?

@dularion dularion merged commit 8eaf6c6 into streamaserver:grails3 Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants