Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable emoji in config #8

Closed
snaerth opened this issue Dec 5, 2018 · 12 comments
Closed

Disable emoji in config #8

snaerth opened this issue Dec 5, 2018 · 12 comments

Comments

@snaerth
Copy link
Contributor

snaerth commented Dec 5, 2018

I love you package and my team wants to use it. But some are not happy with the emoji. Could you provide an option in the changelog.config.js that maybe disables emojis instead of showing a question mark

@snaerth
Copy link
Contributor Author

snaerth commented Dec 6, 2018

@streamich

@streamich
Copy link
Owner

Hi, there is an option to specify specify a custom emoji. So if you set it to, say empty string '', it makes it a question mark?

@snaerth
Copy link
Contributor Author

snaerth commented Dec 6, 2018

Yes if emoji is empty then it will default to question mark

@streamich
Copy link
Owner

@snaerth
Copy link
Contributor Author

snaerth commented Dec 7, 2018

You are misunderstanding me. I would like there to be no question mark if emoji is empty. Just an empty string

@streamich
Copy link
Owner

I think I understood you :), I'm just showing you where to remove the question mark.

@snaerth
Copy link
Contributor Author

snaerth commented Dec 7, 2018

@streamich do you want me to a PR for this?

@streamich
Copy link
Owner

Yes, please

@snaerth
Copy link
Contributor Author

snaerth commented Dec 10, 2018

@streamich
#9

@snaerth
Copy link
Contributor Author

snaerth commented Dec 10, 2018

@streamich thx for the merge. Could you as well update the package on npm for us to start using it?

@streamich
Copy link
Owner

@snaerth Thanks, your change should be now available in version 1.8.0.

@snaerth
Copy link
Contributor Author

snaerth commented Dec 10, 2018

Great thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants