Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-out emojis #41

Closed
rfoel opened this issue May 14, 2019 · 8 comments
Closed

Opt-out emojis #41

rfoel opened this issue May 14, 2019 · 8 comments

Comments

@rfoel
Copy link

rfoel commented May 14, 2019

As addressed here #8, we can disable emojis in commits by not sending them configuring the changelog.config.js file.

Now my question is: how can we opt-out them completely? I configured the file but whenever there is a breaking change or an issue closing commit, the emojis 🧨 and ✅are being sent. I see no option except to fork and remove them myself.

@semoal
Copy link

semoal commented Jun 11, 2019

@rfoel Hi Rafael, pull request submitted.

While this gets revised, and merged you could do this in changelog.config.js

module.exports = {
  "breakingChangePrefix": "",
  "closedIssuePrefix": "",
  "list": [
    "test",
    "feat",
    "fix",
    "chore",
    "docs",
    "refactor",
    "style",
    "ci",
    "perf"
  ],
  "maxMessageLength": 64,
  "minMessageLength": 3,
  "questions": [
    "type",
    "scope",
    "subject",
    "body",
    "breaking",
    "issues",
    "lerna"
  ],
  "scopes": [],
  "types": {
    "chore": {
      "description": "Build process or auxiliary tool changes",
      "emoji": "",
      "value": "chore"
    },
    "ci": {
      "description": "CI related changes",
      "emoji": "",
      "value": "ci"
    },
    "docs": {
      "description": "Documentation only changes",
      "emoji": "",
      "value": "docs"
    },
    "feat": {
      "description": "A new feature",
      "emoji": "",
      "value": "feat"
    },
    "fix": {
      "description": "A bug fix",
      "emoji": "",
      "value": "fix"
    },
    "perf": {
      "description": "A code change that improves performance",
      "emoji": "",
      "value": "perf"
    },
    "refactor": {
      "description": "A code change that neither fixes a bug or adds a feature",
      "emoji": "",
      "value": "refactor"
    },
    "release": {
      "description": "Create a release commit",
      "emoji": "",
      "value": "release"
    },
    "style": {
      "description": "Markup, white-space, formatting, missing semi-colons...",
      "emoji": "",
      "value": "style"
    },
    "test": {
      "description": "Adding missing tests",
      "emoji": "",
      "value": "test"
    }
  }
};

@warapitiya
Copy link
Contributor

I personally think emoji should be a feature rather than a default behavior.

@semoal
Copy link

semoal commented Jul 1, 2019

I personally think emoji should be a feature rather than a default behavior.

I don't care too much about... I like them when I see a git history it tooks really easy to find all the commits related to a bug.

As @streamich, changing the default behavior is pretty easy with the pull request i submitted but would imply a breaking change...

@warapitiya
Copy link
Contributor

Maybe some people like it. But most of my team members don't like it including me. Without emojis, it looks professional.

@semoal
Copy link

semoal commented Jul 2, 2019

Maybe some people like it. But most of my team members don't like it including me. Without emojis, it looks professional.

Okay, so disable it. It's a conversation that ends with the same final.

@MaxRazen
Copy link

MaxRazen commented Jul 3, 2019

Hi @semoal
Can I register config globally and how if it possible?

@semoal
Copy link

semoal commented Jul 4, 2019

Hi @semoal
Can I register config globally and how if it possible?

Look the readme of the project.

module.exports = {
  "disableEmoji": false,
   ...
};

@streamich
Copy link
Owner

streamich commented Jul 16, 2019

It is now possible to opt-out of emojis completely using local config (#55).

{
  "disableEmoji": false,
};

@maxwell-hub I've create an issue to add a global config: #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants