Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add commitMessageFormat #110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hashiguchip
Copy link

I added the feature to change the commit message format

#81

@hashiguchip hashiguchip marked this pull request as ready for review December 19, 2019 13:06
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the flexibility this feature adds, only we need to be careful to still support the old message format. For example, config.disableEmoji seems not to be respected anymore. For this change it is probably worth adding few unit tests. I have added a commit to this PR with a couple of unit tests, but I think we should test more cases.

scope = `(${answers.scope})`;
}

if (config.disableEmoji) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that config.disableEmoji setting is not being handled in the new code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's currect. I fixed it !

@hashiguchip
Copy link
Author

hashiguchip commented Jan 19, 2020

@streamich
Thank you for watching my PR!
I agree with what you are saying which should respect disableEmoji.
Anyway, I added code to pass unit test which you added.
Please validate it.

@stepankuzmin
Copy link

Hi everyone! Is there are change for this to get merged? Really missing the ability to change commit format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants