-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 add commitMessageFormat #110
base: master
Are you sure you want to change the base?
feat: 🎸 add commitMessageFormat #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the flexibility this feature adds, only we need to be careful to still support the old message format. For example, config.disableEmoji
seems not to be respected anymore. For this change it is probably worth adding few unit tests. I have added a commit to this PR with a couple of unit tests, but I think we should test more cases.
scope = `(${answers.scope})`; | ||
} | ||
|
||
if (config.disableEmoji) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that config.disableEmoji
setting is not being handled in the new code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's currect. I fixed it !
@streamich |
Hi everyone! Is there are change for this to get merged? Really missing the ability to change commit format |
I added the feature to change the commit message format
#81