Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: 🎸 check for staged files" #180

Merged
merged 1 commit into from
May 26, 2020
Merged

Revert "feat: 🎸 check for staged files" #180

merged 1 commit into from
May 26, 2020

Conversation

streamich
Copy link
Owner

Reverts #178

@streamich
Copy link
Owner Author

Build version: 4.5.0-pr-180.822 🤞 revert-178-staged-files-check on Travis 🎉

@streamich streamich merged commit 7de648a into master May 26, 2020
@streamich streamich deleted the revert-178-staged-files-check branch May 26, 2020 09:18
@streamich
Copy link
Owner Author

I guess we should do this check without ! and maybe when there are no staged files instead of failing add a step to the wizard "You don't have any files staed. Press Enter when you have files staged."

@streamich streamich mentioned this pull request May 26, 2020
Closed
@vaibhavarora14
Copy link

hey @streamich ,
were you able to find, why command was not succeeding in finding staged files?

@vaibhavarora14
Copy link

oops I missed the fact that it's your repository 😅

@streamich
Copy link
Owner Author

🎉 This PR is included in version 4.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@streamich @vaibhavarora14