"utimes" doesn't work for directories: "EISDIR: illegal operation on a directory, open ..." error

[vladimiry]

utimes calls utimesBase which uses openSync call internally but openSync call on a directory obviously throws EISDIR error.

memfs/src/volume.ts

Lines 1771 to 1778 in 674a1e7

	private utimesBase(filename: string, atime: number, mtime: number) {
	const fd = this.openSync(filename, 'r+');
	try {
	this.futimesBase(fd, atime, mtime);
	} finally {
	this.closeSync(fd);
	}
	}

[kellym]

I've also run into this issue. Any solutions?

[kellym]

This seems related to #58. Maybe r is too restrictive there? Modifying those lines seems to fix the issue for me.

[williamstein]

For what it is worth, here is how I fixed this in my fork (following your suggestions above, and adding a test):

~/upstream/memfs-js$ git show HEAD
commit 671af81ba00e546a10581217f43d32f2406dec6b (HEAD -> main)
Author: William Stein <wstein@sagemath.com>
Date:   Tue Oct 25 17:56:15 2022 -0700

    fix #2 -- utimesSync doesn't work on directories
    
    - also is upstream https://github.com/streamich/memfs/issues/391

diff --git a/src/__tests__/volume.test.ts b/src/__tests__/volume.test.ts
index 53a1f89..39c39f2 100644
--- a/src/__tests__/volume.test.ts
+++ b/src/__tests__/volume.test.ts
@@ -961,10 +961,17 @@ describe('volume', () => {
     });
     describe('.utimesSync(path, atime, mtime)', () => {
       const vol = new Volume();
+      vol.mkdirSync('/foo');
       it('Set times on file', () => {
-        vol.writeFileSync('/lol', '12345');
-        vol.utimesSync('/lol', 1234, 12345);
-        const stats = vol.statSync('/lol');
+        vol.writeFileSync('/foo/lol', '12345');
+        vol.utimesSync('/foo/lol', 1234, 12345);
+        const stats = vol.statSync('/foo/lol');
+        expect(Math.round(stats.atime.getTime() / 1000)).toBe(1234);
+        expect(Math.round(stats.mtime.getTime() / 1000)).toBe(12345);
+      });
+      it("Sets times on a directory (see https://github.com/streamich/memfs/issues/391)", () => {
+        vol.utimesSync('/foo', 1234, 12345);
+        const stats = vol.statSync('/foo');
         expect(Math.round(stats.atime.getTime() / 1000)).toBe(1234);
         expect(Math.round(stats.mtime.getTime() / 1000)).toBe(12345);
       });
diff --git a/src/volume.ts b/src/volume.ts
index b34860e..e4b05e8 100644
--- a/src/volume.ts
+++ b/src/volume.ts
@@ -1882,7 +1882,7 @@ export class Volume {
   }
 
   private utimesBase(filename: string, atime: number, mtime: number) {
-    const fd = this.openSync(filename, 'r+');
+    const fd = this.openSync(filename, 'r');
     try {
       this.futimesBase(fd, atime, mtime);
     } finally {

[G-Rath]

@williamstein I'm happy to review a pull request if you want to open one 🙂

[williamstein]

I'm happy to review a pull request if you want to open one

Cool! I will.

[williamstein]

OK, I created #866 for this.

[G-Rath]

Thanks, I'll have a look once I'm off work - it seems like you need to apply prettier to your PRs too.

[williamstein]

Thanks, I'll have a look once I'm off work - it seems like you need to apply prettier to your PRs too.

Done.

This memfs codebase is some unusually good quality code. Thanks for maintaining it!

[streamich]

🎉 This issue has been resolved in version 3.4.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀