PR useAsyncFn
callback promise rejection propagation
#1755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found an easy way to do not swallow error in
useAsyncFn
callback. This is potentially a breaking change, because thecallback
returned from hook behave differently now, but for me now it makes more sense, especially when we want to fire more side effect connect to this one (e.g. save data and if succeed move to next route).If this breaking change can't be merged, maybe introducing a new hook with behavior described in this PR will be a way?
This fixes the issue described here #612
Type of change
Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).