Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation block tests #554

Merged
merged 12 commits into from
Aug 23, 2019
Merged

Conversation

Belco90
Copy link
Contributor

@Belco90 Belco90 commented Aug 22, 2019

Add tests for animation hooks block #101
This one was hard to test, specially useRaf and useSpring but I learnt a lot testing them!

This include tests for:

  • useRaf
  • useSpring
  • useTimeout
  • useUpdate
  • useTimeoutFn (already done by someone else! I just adapt it to have same structure as others)

The PR also includes some bug fixes!

@Belco90 Belco90 mentioned this pull request Aug 22, 2019
34 tasks
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@streamich streamich merged commit d7a622d into streamich:master Aug 23, 2019
@streamich
Copy link
Owner

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@streamich
Copy link
Owner

@Belco90 I've sent you a collab invite.

@Belco90
Copy link
Contributor Author

Belco90 commented Aug 24, 2019

Awesome! Thanks for the collab invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants