Memoized utils methods for useMap #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xobotyi
approved these changes
Sep 5, 2019
Belco90
suggested changes
Sep 5, 2019
| utils.set('foo', 'baz'); | ||
| }); | ||
|
|
||
| expect(result.current[1]).toBe(utils); |
There was a problem hiding this comment.
You are checking here that utils object is the same instance, but that doesn't mean that returned callbacks are same instances, so you would have to check that utils.get is result.current[1].get and so on.
There was a problem hiding this comment.
In fact it does mean that internals are the same (due to useMemo instead of bunch of useCallback), but that, more precise check of result.current[1].get wont be excessive.
There was a problem hiding this comment.
It is indeed working just fine, but I guess an additionnal test assertion can make it more visible
Belco90
approved these changes
Sep 5, 2019
|
🎉 This PR is included in version 12.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
Here is my proposal following the issue #456
All feedbacks are more than welcome
Cheers