-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support unwatchFile
#557
Conversation
+1 for this if anyone is around to review... I stumbled across the error and it led me here! |
@aleung it looks like your test might be a bit unstable - would you be willing to look into that for us? |
@G-Rath The test failed in "union › Union › Streams › can create Writable Streams" but I didn't change this one. The test added in my PR is "union › Union › sync methods › watch() › can watchFile and unwatchFile". Anyway, I'll try to run test locally to verify it. |
@aleung yeah that failure is a different one. The failure from this PR seems to only happen when you run the tests multiple times (so won't show up in CI) due to files being created so it looks like it behaves differently on subsequent runs. Thanks for looking into this! I'm a bit slammed at the moment so any time you can spare is appreciated 😊 |
@aleung it looks like the issue was just timing - adding another call to |
@G-Rath Great. Do you need any more action from me? |
@aleung at the time no, but now it looks like after a general lockfile update (#758) a new issue has start occuring:
|
It looks like the issue is because of streamich/memfs#902 |
# [4.5.0](v4.4.0...v4.5.0) (2023-06-02) ### Features * support `unwatchFile` ([#557](#557)) ([721f49d](721f49d))
This has now been released in 4.5.0 🎉 |
unwatchFile