Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send bytes instead of bytes of string #19

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saihaj
Copy link

@saihaj saihaj commented Jul 3, 2023

while debugging issue on some other subgraph found that we were storing the base64 that was because it was converting String -> bytes but we want to store the bytes directly so we can use the Bytes type in subgraphs to show the Hex value nicely

context: https://guild-oss.slack.com/archives/C03B2US85J4/p1688395836580659?thread_ts=1688359311.715519&cid=C03B2US85J4

@maoueh
Copy link
Contributor

maoueh commented Jul 3, 2023

Let's not change the proto definition, there is just too much chance of uncovered breaking change.

Let's just fix the graph_out to emit the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants