Video generation fails when creating a video from images and @movie is nil #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report. Could you add specs that cover the use case, please? |
|
@nbouhid , I reworked the changes to transcoder and added a spec. Does this cover your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was having problems when trying to generate a video from screenshots.
I found out that the trasceiver.rb file is assuming a @movie exists, even when it doesn't.
I just added a check for that scenario, and a fallback value for it.
Then it works.
Could you take a look? I wasn't sure about what progress number to fallback. I set -1 because to me it basically means, "invalid to determine" since we don't have a video to check for and properly return a progress value.
Thanks
Nice plugin BTW