Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize to tray / --tray parameter not working correctly #632

Closed
2 tasks done
NickSharf opened this issue Apr 9, 2019 · 1 comment
Closed
2 tasks done

Minimize to tray / --tray parameter not working correctly #632

NickSharf opened this issue Apr 9, 2019 · 1 comment
Labels
bug

Comments

@NickSharf
Copy link

NickSharf commented Apr 9, 2019 •
edited
Loading

Bug report

  • I understand the difference between Streamlink and Streamlink Twitch GUI.
  • This is a bug report and I have read the contribution guidelines.

Environment details

Operating system and version:

mac os 10.14.4

Streamlink Twitch GUI version:

1.7.0

Streamlink version:

1.1.1

Configuration details:

External Commands: Enabled

Description

When I add --tray as launch parameter (open -a "Streamlink Twitch GUI.app" --args --tray) the app starts but icon in Dock still exists

Expected / Actual behavior

Expected: Launches gui without app icon in mac os Dock
Actual: Launches with app icon in Dock

Reproduction steps

  1. Open app from Terminal with --tray parameter:
    open -a "Streamlink Twitch GUI.app" --args --tray

Log output

Additional comments, screenshots, etc.
@bastimeyer
Copy link
Member

Both the --tray launch parameter and "Minimize to tray" option currently don't remove the app icon from the taskbar/dock. This needs to be fixed.

@bastimeyer bastimeyer added the bug label Apr 9, 2019
@bastimeyer bastimeyer changed the title --tray parameter is broken on mac os Minimize to tray / --tray parameter not working correctly Apr 9, 2019
bastimeyer added a commit that referenced this issue Apr 17, 2019
@bastimeyer
Explicitly hide taskbar/dock icon on --tray
9e4d81f 
Default visibility value is already false and only gets set to true
after initialization or when the window gets shown for the first time,
but this seems to be ignored on macOS.

Fixes #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bastimeyer @NickSharf