Remove private api stuff #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 85.3% 85.38% +0.07%
==========================================
Files 466 444 -22
Lines 14059 13702 -357
Branches 1257 1238 -19
==========================================
- Hits 11993 11699 -294
+ Misses 1972 1912 -60
+ Partials 94 91 -3 |
bastimeyer
force-pushed
the
remove-private-api-stuff
branch
from
014b66b
to
5da4926
Compare
bastimeyer
force-pushed
the
remove-private-api-stuff
branch
from
0153ae2
to
037ef04
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #681
This removes everything that is related to the private Twitch API endpoints which are now blocked when requested with third party client-IDs.
As mentioned in #681, channel panels are still available, but only via Twitch's client-id and since Twitch's website has moved to their new private API based on GraphQL a long time ago, it is questionable how long channel panels will still be available on the old private API. I don't really want to use Twitch's client-id in the Twitch GUI, so I'm removing this feature for now.
Also, followed games may be available on the kraken v5 API (undocumented, similar to the old endpoints on the private API), but since unfollowing games doesn't seem to be possible, I don't want to keep this feature.
Should any of these restricted API endpoints become available on kraken (unlikely, since it's been deprecated) or on helix, I will try to re-implement them.
Checklist