New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n/fr: fix some errors #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 88.44% 88.44%
=======================================
Files 457 457
Lines 14983 14983
Branches 1310 1310
=======================================
Hits 13252 13252
Misses 1648 1648
Partials 83 83 |
Thanks a lot for the fixes, looks good! Since I can't do it myself, would you please be so kind and take a look at the remaining missing French translations and add them real quick? New stuff has been added to the app over the past months and only the The missing translation keys can be seen by running These translation keys are compared against the I would really appreciate if you could do this, so that there are no more missing translations. Thank you! |
Sure ! I saw some translations missing but didn't know how to add them. |
If you prefer opening a new PR for the missing translations, then you can do it of course. I would also be fine with adding them here. I will squash the commits on merge though, so if you want to keep the fixes and addition of missing translations separate, open a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! The changes are looking good and all missing translations have been added. There's one tiny issue though which needs to be fixed before I can merge this. Could you please take a look?
src/app/locales/fr/settings.yml
Outdated
streams: Streams | ||
chat: Chat | ||
languages: Langages | ||
hotkeys: Raccourcis claviers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unfortunately breaks the settings menu's submenu, because the text is too long and the submenu doesn't support overflowing texts/buttons yet.
Is there a shorter translation available? If not, I guess you'll have to use the English menu name. The word "Hotkeys" shouldn't be too bad though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Raccourcis" should be fine and doesn't break the submenu (at least for me).
Yep, that fixes the settings submenu. I'll leave the PR up for another day or so, just in case somebody wants to review or if you find something else to fix. Then I'm going to merge. |
Thanks! |
No description provided.