Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n/es: Spanish translation #818

Merged
merged 23 commits into from Aug 27, 2021
Merged

i18n/es: Spanish translation #818

merged 23 commits into from Aug 27, 2021

Conversation

Relwi
Copy link
Contributor

@Relwi Relwi commented Aug 13, 2021

No description provided.

@bastimeyer bastimeyer added i18n WIP Work in progress labels Aug 13, 2021
@bastimeyer
Copy link
Member

Thanks for the PR, much appreciated. If there's anything you need help with, please ask.

@Relwi Relwi changed the title i18n/es: Spanish translation (in progress) i18n/es: Spanish translation Aug 27, 2021
@Relwi
Copy link
Contributor Author

Relwi commented Aug 27, 2021

Translation finished

@bastimeyer bastimeyer removed the WIP Work in progress label Aug 27, 2021
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
The translations are looking good. There are a couple of minor issues left though. Unless you spot any further mistakes or potential improvements, this can be merged once the issues have been fixed.

src/app/locales/es/settings.yml Outdated Show resolved Hide resolved
src/config/locales.json Outdated Show resolved Hide resolved
src/app/locales/es/modal.yml Outdated Show resolved Hide resolved
Relwi and others added 3 commits August 27, 2021 14:38
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
@Relwi
Copy link
Contributor Author

Relwi commented Aug 27, 2021

Thanks for your help!
I forgot to put the "i18n/es" in the new commits and I'm a newbie doing this things so idk how to change it.
Regarding the translation, I think it is good for now, I didn't see any further mistakes or potential improvements.

@bastimeyer
Copy link
Member

I going to squash the commits when merging anyway, so it's not a problem with the commit messages. Ideally, every translation namespace (each file) would have its own commit when a new language gets added, but rebasing the commits isn't that important now. The most important thing is that each change can be reviewed properly, and this was the case here.

I'll merge this later this evening when I had the time to look over it one last time.
Thanks again for your translations!

@bastimeyer bastimeyer merged commit 7dafe71 into streamlink:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants